Skip to content

Hide commit msg for package files without pipeline

What does this MR do?

This MR fixes a wrong assumption in the frontend that leads to the package files disappearing.

Previously we would decide if to show/hide the commit table row if at least one package had an associated pipeline, there are however situations where some files have a pipeline object and some other not, this MR fixes this last case, allowing for an empty cell when only one is missing the data

Screenshots (strongly suggested)

Note that all the commit messages are absent because we removed the message from the serializer due to a performance issue, the screenshot shows a working table when pipeline is undefined

Screenshot_2021-05-12_at_14.42.26

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #330396 (closed)

Edited by Nicolò Maria Mezzopera

Merge request reports

Loading