Skip to content

The set up for the Feature Flag-driven Startup css

Denys Mishunov requested to merge 322680-startup-css-for-left-panel into master

What does this MR do?

Sets up the basis for serving different versions of the Startup CSS based on the environment variables like a feature flag, for example.

Startup CSS helper changes

  • Introduces startup_css_helper.rb with #startup_css_filename helper method to encapsulate around various variants of the startup css, and uses it from _startup_css.haml.
  • Adds full test coverage for all logic branches of startup_css_helper.rb.
  • startup_css_helper logic can remain unchanged and be used for future feature flags involving changes to the startup css.

To test locally, please, enable the :sidebar_refactor feature flag for your local user. The flag is scoped to the user and is not global

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #322680 (closed)

Edited by Denys Mishunov

Merge request reports

Loading