Skip to content

Audit and update buttons on Profiles::KeysController#get_keys"

What does this MR do?

Updates buttons in Profiles::KeysController#get_keys:

  • Use confirm variant for the Add key button.
  • Use the default variant for the trash buttons.
  • Add tooltip to trash button.

Screenshots

Before After
CleanShot_2021-05-12_at_15.56.37 CleanShot_2021-05-12_at_15.15.33

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #273304 (closed)

Edited by Jeremy Elder

Merge request reports

Loading