Skip to content

Refactored the left panel toggle

What does this MR do?

Slightly refactors the left-side panel's collapse/open toggle. Some things to note in this MR:

  • instead of two chevron icons, we use just one. We simply flip it in the collapsed state
  • instead of raw styles we use utility classes and the SCSS mixins
  • we disable Startup CSS when the Feature Flag (:sidebar_refactor) is enabled. This is to not be confused by styles coming from the Startup CSS stylesheets which are not updated with the changes introduced by the sidebar's refactoring. Since the flag will be scoped to particular people, we don't need to care about the FOUC.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #322680 (closed)

Edited by Denys Mishunov

Merge request reports

Loading