Add new DAST internal API for site validations [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
this merge request introduces a new ee-only internal api for updating dast site validation status for on-demand dast scans. this api will be called from a custom image running in a docker container on a runner to indicate the status of a validation.
Why?
Motivation
currently site validation takes place in a sidekiq job, which isn't always guaranteed to be on the same network as the target application. this prevents customers from performing active scans against targets that aren't accessible from their gitlab instance. moving validation to the runner allows these to be more easily brought into alignment.
Internal API
dast site validation is used as a foot-gun to help prevent customers from scanning the wrong target application. it does not present a security risk to allow this api to be publicly accessible but, since dast on-demand is not yet a mature feature and we do not think this functionality would be useful to customers directly, we've chosen to introduce a new internal api (see context).
Related Issue(s)
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team