Skip to content

Disallow review-deploy job to fail in Frontend and QA MRs

Anastasia McDonald requested to merge a_mcdonald-master-patch-48752 into master

What does this MR do?

Disallows review-deploy job to fail in MRs with Frontend and QA changes. At the moment review-deploy job is allowed to fail and its status is being ignored - so the tests would run (and fail) even when the deployment didn't succeed. Making it blocking ensures needs works as intended for the next qa stage and the tests only run on deploy success.

NB the current Review App deployment success rate is at its highest at 98% - https://app.periscopedata.com/app/gitlab/516343/Quality-Department-KPIs?widget=6721558&udv=0

See gitlab-com/www-gitlab-com#12270 (closed) for more details.

Does this MR meet the acceptance criteria?

Conformity

Edited by Anastasia McDonald

Merge request reports

Loading