Add `MembersTabs` Vue component
📖 What does this MR do?
Related to #324681 (closed)
This MR is an attempt to split up !61524 (merged) into smaller chunks to make it easier to review. Unfortunately this means we lose a bit of context as to how it integrates with the rest of the application.
We are in the process of converting the group/project member Bootstrap tabs to GlTabs
. This MR introduces a MembersTabs
component that will be used in future MRs to achieve this goal. The MembersTabs
component is not yet used and therefore this MR does not introduce any visual/functionality changes.
When we switch to using this component we will render MembersTabs
in app/assets/javascripts/members/index.js#L51 instead of rendering App
.
💻 Local testing
This component is not yet used, you can checkout !61524 (merged) if you would like to test locally with everything wired up.
📷 Screenshots
No visual changes. For context, the screenshots below show what the new tabs will look like once #324681 (closed) is completed (they are supposed to look almost identical
Before | After |
---|---|
🚦 Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) - Not needed as this is a developer facing change
- [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. - [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team