Skip to content

Revert 284471-misc-vulnerability-filters-refactor

Daniel Tian requested to merge revert-6edcb075 into master

What does this MR do?

On the pipeline security tab, a vulnerability list is supposed to be shown. However, a recent MR broke it so that the vulnerability list indefinitely shows a skeleton loader, due to a console error:

This MR reverts that MR, but keeps a few code improvements from the original MR.

Technical Details

The original MR switched from having the dropdowns themselves keep track of which items are selected, to having the querystring track which items are selected. However, this only works on pages that have Vue Router added to them, which the pipeline security tab does not. We discussed if we should add the router to that page as well, but there are some unanswered questions that could take some time to answer, and we need to fix this issue ASAP because it affects production and is 100% reproducible.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Daniel Tian

Merge request reports

Loading