Skip to content

Introduced granular control to Monaco tag

Denys Mishunov requested to merge dmishunov-monaco-tag into master

What does this MR do?

!61112 (merged) introduced the globally preloaded Monaco chunk. However, it had some performance consequences despite the odss. This MR takes the process several steps further by doing the following:

  • Introduces the mechanism of controlling whether to include Monaco on a view or not using :monaco_tag
  • Introduce the new helper for prefetch resource hint to complement the preloading of the resources
  • Updates all existing instances of the Source Editor-enabled routes to eagerly preload or prefetch the chunk

Screenshots (strongly suggested)

No visual changes except for now preloading/prefetching Monaco explicitly on some routes.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

/labels frontend ~performance performance-refinement devopscreate ~"group::editor" Source Editor

Merge request reports

Loading