Skip to content

Setup the status checks store to handle the create/update operations

Implementation stages

Description MR
Setup the store to handle the form 👈 You are here
Create status checks form and branch selection !61700 (merged)
Create new create/update modals to show the form !61702 (merged)

What does this MR do?

With #327638 (closed) we are pivoting the status checks from being developed as part of the MR approval rules section, to its own dedicated section. This is because status checks don't "approve" an MR but rather give the MR author/merger an idea as to whether the MR passes any external processes. Putting it in a separate section helps keep the distinction that you don't need a status check to pass to merge an MR like you do approval rules.

This MR sets up the status checks store to handle the create/update operations coming in future implementation MR's:

  • Added creating settings and posting/putting status checks via the API to store actions
  • Added new settings object to the state
  • Updated the mount to get and store the settings
  • Added the project ID to data generated by the rails helper

Screenshots (strongly suggested)

No visual changes

View Light mode Dark mode Small screens
Empty image image image
With services image image image

Setup & testing

Note: Right now, adding/editing/deleting status checks is functioning within the approval rules section as per previous work. Use this area to control the status checks for now until future MR's move the functionality to the new area

  1. Enable the feature flag :ff_compliance_approval_gates
  2. Go to [HOST]/gitlab-org/gitlab-test/edit and expand the Merge requests section
  3. Check that Status checks is empty
  4. Open the Merge request (MR) approvals section and add a new approval rule using the type Status checks
  5. Check that Status checks contains the added status check

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #327638 (closed)

Edited by Robert Hunt

Merge request reports

Loading