Skip to content

Geo Nodes Beta - Remove "Beta"

Zack Cuddy requested to merge 296986-remove-geo-beta into master

What does this MR do?

This MR is a step required before we can remove the :geo_nodes_beta Feature Flag #296986 (closed).

Currently the UI is leveraging an /admin/geo/nodes and /admin/geo/nodes_beta route to test the new UI without obstructing the current UI. This change removes the separate routes and instead returns to a typical Feature Flag approach where we render one UI or the other based on the FF.

This will allow us to now remove the legacy code and FF in a follow up MR and be sure that everything is in place and isolate any issues that result from the cutover.

This change is also behind a feature flag (:geo_nodes:beta)

How to test

  1. Set up a Geo Primary/Secondary GDK
  2. Fetch the current branch
  3. Activate the Feature Flag on your Primary GDK (:geo_nodes_beta)
  4. Navigate to http://127.0.0.1:3000/admin/geo/nodes_beta
  5. View UI

Screenshots (strongly suggested)

No FF FF
Screen_Shot_2021-05-13_at_12.48.35_PM Screen_Shot_2021-05-13_at_12.47.26_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #296986 (closed)

Edited by Zack Cuddy

Merge request reports

Loading