Fix missing system notes and system events on create issue [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
This MR fixes an edge case of some resource events and corresponding system notes for issues not being created when an issue is created. The problem occurs when for instance at issue creation time user selects a milestone and and epic(important), in which case even though both milestone and epic are assigned to the issue the event about issue being assigned to a milestone is missing, thus making the burndown/burnup charts to display erroneous information.
The problem was related to the fact that we were saving the epic_issue relationship before saving the issue itself and before handling the changes on the issue. Saving the epic_issue triggers an issue save as well. So when we save the issue explicitly lated on we see no date in previous_changes hash, thus leading to the code that used previous_changes hash to handle creation of resource events to not save corresponding data.
The same issue occurred for assignees.
| before | after |
|---|---|
| before-1 | after-1 |
| before-2 | after-2 |
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team