Add frontend feature flag check for codequality diff badge
What does this MR do?
This MR adds a frontend feature flag check for the codequality_mr_diff
feature flag in order to show the badge in the MR diff file header only if this flag is enabled.
The badge is already only shown if there is data for the file, and the data is already only loaded if the feature flag is enabled, but we are now building a feature that uses the same data under a different feature flag, so we need to alter this feature flag to control the visibility of the badges.
This MR makes changes to the feature flag :codequality_mr_diff
- echo "Feature.enable(:codequality_mr_diff)" | rails c
to enable it
Screenshots
There should be no visual changes, but here is the feature:
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related feature issues: #267612 (closed), #2526 (closed)
Related feature flag rollout issues: #284140 (closed), #330909 (closed)