Draft: Recognize uploads through fog gem to be file storage
What does this MR do?
While uploading Terraform State files, we use carrierwave
and fog
gems.
When checking if the file's checksum can be calculated, we check what the file storage object is. For Terraform uploads through Terraform::StateUploader
we expect the storage to specifically be of the type CarrierWave::Storage::File
, but when external object storage is used, the storage is actually of type Carrierwave::Storage::Fog
. Both these classes inherit from CarrierWave::Storage::Abstract
.
This discrepancy breaks checksum calculation for Geo.
One solution is to check explicitly for both these classes.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team