Skip to content

Fix pipeline status for commit caching

Robert May requested to merge fix-commit-cache-key into master

What does this MR do?

I made a mistake in !56092 (closed) and managed to create a cache key that rotates on every page load 😅

This MR fixes that key to delegate to the actual pipeline cache key, which will rotate as the status is updated. The previous MR is still behind a feature flag so no changelog is required yet. I've also expanded test coverage to make sure the key is actually what I meant it to be.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert May

Merge request reports

Loading