Skip to content

Remove unncessary group SAML identity assignment

Drew Blessing requested to merge dblessing_saml_user_identity_fix into master

What does this MR do?

Follow-up to !61717 (merged).

As previously implemented the code was technically buggy and could cause confusion in the future. That is because the call to self.identity, if an update were necessary, would fail to update user identities association and would not be auto-saved.

Actually, it wouldn't be possible for the identity to be found in this manner if the extern_uid had changed. Make it clearer by using a guard to indicate nothing is happening in this case.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Drew Blessing

Merge request reports

Loading