Use specialized worker to refresh authorizations on project-group share update
What does this MR do?
This change implements #322442 (closed)
Feature flag rollout issue: #334234 (closed)
Advantage
From Kibana, this endpoint enqueued over 4000 AuthorizedProjectsWorker
jobs in the last 7 days. (This number can vary up or down easily based on traffic, number of project members in the shared group etc)
The fact is that this endpoint can enqueue N
different AuthorizedProjectsWorker
jobs (where N
= number of members in the group), which is what happens internally when we call link.group.refresh_members_authorized_projects
.
With the new approach introduced in this MR, instead of N
jobs, there will be just 1
AuthorizedProjectUpdate::ProjectRecalculateWorker
enqueued when a project-group share update happens (and if it needs auth recalculation)
However, till we are satisfied with the correctness of AuthorizedProjectUpdate::ProjectRecalculateWorker
, we are still gonna run group.refresh_members_authorized_projects
as a safety-net with a 1 hour delay. We will be comparing the correctness of both approaches using Kibana after the change is deployed, just like we did here.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team