Skip to content

Remove 30 minutes warning from GitLab Pages

Vladimir Shushlin requested to merge vshushlin-remove-pages-30-min into master

What does this MR do?

We originally added it because Pages daemon reload took up to 30 minutes to rescan configuration files on disk storage for gitlab.com

We aren't using these configuration files for gitlab.com for more than a year already, and use API, which works almost instantly.

On smaller instances there were no such problems, and we remove support for these configuration files in 14.0 anyway, so self-managed customers will also move to the API.

Screenshots (strongly suggested)

Before

Screenshot_2021-05-18_at_11.59.25

After

Screenshot_2021-05-18_at_12.00.04

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Vladimir Shushlin

Merge request reports

Loading