Refactor LabelToken to use BaseToken
What does this MR do?
This MR updates filtered_search_bar/tokens/label_token.vue
to use filtered_search_bar/tokens/base_token.vue
which includes all the common bits for all token types. This also allows us to enable Recently used
feature for Label Token where last 3
recently used values show up immediately while opening the dropdown.
Screenshots (strongly suggested)
Dropdown Menu | Behaviour |
---|---|
Screen_Recording_2021-05-18_at_4.23.42_PM |
Does this MR meet the acceptance criteria?
Conformity
-
I have not included changelog as the feature is currently enabled only for Vue Epics List which is behind FF. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team