Skip to content

Fix double render in project's git URL redirect

Heinrich Lee Yu requested to merge fix-projects-double-render into master

What does this MR do?

When you visit the git URL of a project using a browser, we redirect to the project's URL without the git suffix.

When a project is moved, visiting the old URL results in a 500 because we're calling redirect_to twice in the same before_action.

This MR fixes the problem.

https://sentry.gitlab.net/gitlab/gitlabcom/issues/2599907

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports

Loading