Skip to content

Fix for cache key oversight

Robert May requested to merge fix-commit-cache-key-again into master

What does this MR do?

So it turns out when Rails expands cache keys it doesn't do so for hash values. That's a new one to me 🤷 This MR fixes the cache keys, for reals this time, for the commit partial cache currently being tested out.

Still behind a feature flag so no changelog here.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert May

Merge request reports

Loading