Advanced Search: Remove legacy ReindexingService
What does this MR do?
To support reindexing processes in progress when making the change to support retries, the original service was renamed LegacyReindexingService and kicked off if the Elastic::ReindexingSubtask had an elastic_task record filled out. We need to clean up that logic to remove the legacy service and all related specs in the following files:
-
ee/app/services/elastic/legacy_reindexing_service.rb -
ee/app/workers/elastic_cluster_reindexing_cron_worker.rb -
ee/spec/services/elastic/legacy_reindexing_service_spec.rb -
ee/spec/workers/elastic_cluster_reindexing_cron_worker_spec.rb
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Closes #329566 (closed)
Edited by Dmitry Gruzd