Skip to content

Fix incorrect path parsing when name ends with ref

Samantha Ming requested to merge 330947-incorrect-ref-commit into master

What does this MR do?

This MR fixed the problem when the project name ends with the same name as the current ref.

Problem Fixed
problem-when-project-last-name-contains-ref fixed
image image

Testing Case

Create a project name anything-bug and a branch called bug

  1. Navigate to Repository > Files
  2. Ensure you're on the bug branch
  3. Switch to the master branch
  • It successfully switches the branch and no flash message is thrown.

Follow up MR

Test to follow 💪 -- As this is affecting production, I think it's best we push up a fix asap and take care of the feature specs in a follow up 😀

Note

This underlying problem of this issue is due to this > #327085 (closed). So this MR offers a band-aid solution to stop the problem in production. A better long term solution is in the works, so stay tuned 😄

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #330947 (closed)

Edited by Robert Hunt

Merge request reports

Loading