Skip to content

Moved contextual-header styles out of the left column

Denys Mishunov requested to merge 322680-refactor-stylesheet into master

What does this MR do?

The MR refactors the contextual_sidebar.scss so that the .contextual-header is not part of the stylesheet. The reason is that .contextual-header is used outside of the conventional sidebar (like in WebIDE) and we do not want to break the styling there while working on refactoring of the left-hand panel in the context of &5647 (closed)

Screenshots (strongly suggested)

Expanded column

View Before After
Project Screenshot_2021-05-19_at_16.15.00 Screenshot_2021-05-19_at_16.21.24
Group Screenshot_2021-05-19_at_16.15.09 Screenshot_2021-05-19_at_15.58.00
Admin Screenshot_2021-05-19_at_16.15.18 Screenshot_2021-05-19_at_16.21.41
User preferences Screenshot_2021-05-19_at_16.15.25 Screenshot_2021-05-19_at_15.58.18
WebIDE Screenshot_2021-05-19_at_16.14.22 Screenshot_2021-05-19_at_15.58.08

Collapsed column

View Before After
Project Screenshot_2021-05-19_at_16.14.53 Screenshot_2021-05-19_at_15.58.38
Group Screenshot_2021-05-19_at_16.14.46 Screenshot_2021-05-19_at_15.58.44
Admin Screenshot_2021-05-19_at_16.14.37 Screenshot_2021-05-19_at_15.58.50
User preferences Screenshot_2021-05-19_at_16.14.31 Screenshot_2021-05-19_at_15.58.56
WebIDE does not have collapsed state does not have collapsed state

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #322680 (closed)

Edited by Denys Mishunov

Merge request reports

Loading