Moved right-sidebar styles out of the left column
What does this MR do?
This MR is a continuation of the cleanup in contextual_sidebar.scss aiming at leaving only the styles related to the left-hand panel in this stylesheet to make the refactoring more predictable and less fragile.
This MR in particular moves out the .toggle-right-sidebar-button CSS class out into the right panel's stylesheet (sidepanel.scss) as it does not belong to the left panel at all.
To test the change one should go either to one of:
- Project settings → CI/CD → Test Cases → Open/Create a test case
- JIRA issues (if the Jira integration is set up)
These are the only two usecases for .toggle-right-sidebar-button
Screenshots (strongly suggested)
| Description | Before | After |
|---|---|---|
| Right panel (expanded) |  |
 |
| Right panel (collapsed) |  |
 |
| Left panel (expanded) |  |
 |
| Left panel (collapsed) |  |
 |
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #322680 (closed)