Skip to content

Simplify route caching lookup

Robert May requested to merge route-caching-simplified into master

What does this MR do?

Fix for the work in !57027 (merged). Turns out the preload-detection stuff can't possibly work due to the way in which the route relationship is configured - we can't do route.present? without performing the query we're trying to avoid. So this MR removes all the code around that and just goes straight to the cached form.

Related #325334 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert May

Merge request reports

Loading