Add Apollo to "Jira Issues List" Vue app
What does this MR do?
As part of an effort to move the Jira Issues feature to GraphQL (&5882), this frontend MR adds Apollo to the Jira Issues List app, and defines a client-side (@client
) resolver for the new jiraIssues
query. This resolver performs the same GET
request as previously. This client-side resolver is temporary, and will be refactored again once we build backend support for this GraphQL query in #329075.
There are no user-facing changes.
For more info on this approach, here's our docs on Implementing frontend queries and mutations ahead of the backend.
Related to #329074 (closed).
To test
To properly test, you'll need a Jira instance with some pre-existing issues. Search jira
in the Engineering 1password vault to find our shared instance credentials.
You'll then need to configure your Jira integration within GitLab, and enable the View Jira Issues feature.
Screenshots (strongly suggested)
The video below demonstrates that all functionality works as expected. Don't hesitate to see for yourself, though!
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team