Skip to content

Remove data-testids in favour of testing by label text

Coung Ngo requested to merge cngo-remove-data-testids into master

What does this MR do?

This MR removes unneeded data-testids in app/assets/javascripts/issuable in favour of testing by label text / findComponent.

Testing what the user sees is what we recommend

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports

Loading