Skip to content

Geo Node Status 2.0 - Refactor Popovers

Zack Cuddy requested to merge 215630-refactor-geo-popover into master

What does this MR do?

Closes #215630 (closed)

In the New Geo UI we use the geo-progress-bar for multiple types of data. However, the popovers in the component had hard coded labels. This isn't flexible enough for the data it represents. This adds props to allow for overriding of the labels where needed.

This change is also behind a feature flag (:geo_nodes_beta)

How to test

  1. Set up a Geo Primary/Secondary GDK
  2. Fetch the current branch
  3. Activate the Feature Flag on your Primary GDK (:geo_nodes_beta)
  4. Navigate to http://127.0.0.1:3000/admin/geo/nodes_beta
  5. View UI

Screenshots (strongly suggested)

before after
Checksum Screen_Shot_2021-05-20_at_1.35.46_PM Screen_Shot_2021-05-20_at_1.31.25_PM
Slots Screen_Shot_2021-05-20_at_1.35.52_PM Screen_Shot_2021-05-20_at_1.31.32_PM
Sync Screen_Shot_2021-05-20_at_1.35.58_PM Screen_Shot_2021-05-20_at_1.31.38_PM
Verification Screen_Shot_2021-05-20_at_1.36.04_PM Screen_Shot_2021-05-20_at_1.31.44_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #215630 (closed)

Edited by David O'Regan

Merge request reports

Loading