Missing impersonation details on MR approval rule audit events
requested to merge 331470-missing-impersonation-details-on-mr-approval-rule-audit-events into master
What does this MR do?
Record impersonation details on Auditor
Audit events captured on MR approval rule changes do not include
impersonation details. The legacy service (i.e. AuditEventService
) is
capable of recording impersonation details. We'd like to replicate this
behaviour on the new service Gitlab::Audit::Auditor
.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #331470 (closed)
Edited by Max Woolf