Skip to content

Resolve "Linear traversal version of EE::Namespace#any_project_with_shared_runners_enabled? is slow"

What does this MR do?

Refine linear capabilities for the Namespace#all_projects method which is used by the EE::Namespace#any_project_with_shared_runners_enabled? method.

The current SQL performs poorly in production...

SELECT 
  "projects".* 
FROM 
  "projects" 
WHERE 
  "projects"."namespace_id" IN (
    SELECT 
      "namespaces"."id" 
    FROM 
      "namespaces" 
    WHERE 
      (
        traversal_ids @ > ('{1}')
      )
  )

The new plan should work much better...

SELECT 
  "projects".* 
FROM 
  "projects" 
WHERE 
  "projects"."namespace_id" IN (
    SELECT 
      traversal_ids[array_length(traversal_ids, 1) ] AS id 
    FROM 
      "namespaces" 
    WHERE 
      (
        traversal_ids @ > ('{1}')
      )
  )

#331429 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #331429 (closed)

Edited by Imre Farkas

Merge request reports

Loading