Enforce SSH key expiration by default
What does this MR do?
This change sets the default value of enforce_ssh_key_expiration
on
the application_settings
table to be true
. We also update existing
settings to be true
. Users will no longer be able to use expired SSH
keys to authenticate to GitLab.
🐘 Databases
Migrate
== 20210531070452 DefaultEnforceSshKeyExpiration: migrating ===================
-- change_column_default(:application_settings, :enforce_ssh_key_expiration, {:from=>false, :to=>true})
-> 0.0526s
== 20210531070452 DefaultEnforceSshKeyExpiration: migrated (0.0527s) ==========
== 20210531071107 EnableEnforceSshKeyExpiration: migrating ====================
== 20210531071107 EnableEnforceSshKeyExpiration: migrated (0.0723s) ===========
Rollback
== 20210531071107 EnableEnforceSshKeyExpiration: reverting ====================
== 20210531071107 EnableEnforceSshKeyExpiration: reverted (0.0000s) ===========
== 20210531070452 DefaultEnforceSshKeyExpiration: reverting ===================
-- change_column_default(:application_settings, :enforce_ssh_key_expiration, {:from=>true, :to=>false})
-> 0.0523s
== 20210531070452 DefaultEnforceSshKeyExpiration: reverted (0.0595s) ==========
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #320970 (closed) and #331928 (closed)
Edited by Tan Le