Fix "Leave this group" button for subgroups listed in group overview.
📖 What does this MR do?
Related to #327403 (closed)
Fixes the "Leave this group" button for subgroups listed in group overview. Previously the action prop was not being passed to the item-actions component and this was causing issues. This MR correctly passes the action prop, adds a regression unit test, and does some spec refactoring to make it easier to add the regression test.
💻 Local testing
- Create a group
- Create a subgroup within that group
- Navigate to the parent group overview
- Click the "Leave this group" button next to the subgroup
📹 Videos
| Before | After |
|---|---|
| Screen_Recording_2021-05-25_at_12.34.15_PM | Screen_Recording_2021-05-25_at_12.40.02_PM |
🚦 Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. - [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman