Skip to content

Fix alignment of global alerts

Peter Hegman requested to merge 326732-alignment-problem-with-error-banner into master

📖 What does this MR do?

Related to #326732 (closed)

Fixes alignment of "Open registration is enabled on your instance." and "Auto DevOps enabled" global alerts. To ensure that styles will be consistent across all global alerts this MR also creates a new _global_alert.html.haml partial. Once this is merged issues will be opened to refactor all other global alerts to use the _global_alert.html.haml partial.

💻 Local testing

  1. Delete the hide_auto_devops_implicitly_enabled_banner_<project_id> cookie
  2. Delete the UserCallout record for the "Open registration is enabled on your instance." alert
    • bin/rails console
    • UserCallout.where({ feature_name: 25 }).destroy_all
  3. Navigate to a project

📷 Screenshots

Before After
Screen_Shot_2021-05-25_at_12.59.06_PM Screen_Shot_2021-05-25_at_1.03.34_PM
Screen_Shot_2021-05-25_at_1.01.00_PM Screen_Shot_2021-05-25_at_1.03.58_PM

🚦 Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports

Loading