Move data fields models to Integrations namespace
What does this MR do?
This moves the *TrackerData
models into the Integrations::
namespace
as part of #201855 (closed).
We also rename the related concerns to clarify their intent:
app/models/concerns/services/data_fields.rb
:
- Renamed from
Services::DataFields
toIntegrations::BaseDataFields
. - This is included in the models and acts as a sort of base class.
- It's still a module because converting it into an actual class changes some of the automatic Rails behaviour (such as inferring the table name).
app/models/project_services/data_fields.rb
:
- Renamed from
DataFields
toIntegrations::HasDataFields
. - This is included in the main
Integration
model and provides some helpers to access the associated data fields records.
Both of these are moved into app/models/concerns/integrations
.
Does this MR meet the acceptance criteria?
Conformity
- [-] I have included a changelog entry, or it's not needed. (Does this MR need a changelog?)
- [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #201855 (closed)
Edited by Markus Koller