Skip to content

Consolidate `label_select` on boards

David O'Regan requested to merge 292103 into master

What does this MR do?

This change affects the Epic and Issues boards creation/edit form.

A small MVC for: #292103 (closed). Our aim here is to do away with label_select/base.vue as it was only used in a single place i.e. the board_scope.vue component. In this effort we aim to re-use the new label_select_vue component which is used more widely in the application.

Screenshots (strongly suggested)

Before After
Screenshot_2021-05-28_at_12.31.04 Screenshot_2021-06-01_at_12.54.05
Screenshot_2021-05-28_at_12.31.12 Screenshot_2021-06-01_at_12.54.18
Screenshot_2021-05-28_at_12.31.19 Screenshot_2021-06-01_at_12.54.13

How to test:

Issues

  1. Navigate to Issues > Boards
  2. Either select "Edit Board" or "Create new board"
  3. See label select inside the board scope form

Epics

  1. Enable Epic Boards feature flag echo "Feature.enable(:epic_boards)" | rails c
  2. navigate to Epics > Boards
  3. Either select "Edit Board" or "Create new board"
  4. See label select inside the board scope form

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by David O'Regan

Merge request reports

Loading