Skip to content

Styling the top-level menus

Denys Mishunov requested to merge 322680-left-sidebar-styling into master

What does this MR do?

Introduces the refactored styles for the top-level menus in the left-side panel. It is the first MR with real changes in a series of MRs towards Create:Editor -- 13.11 - 14.0 -- Update Left Sidebar effort.

This MR is ONLY about styling the top-level menus in the expanded state. The fly-out menus, collapsed state, and transitions are not covered by this MR and will follow.

DESIGN

Feature flag

This change is under the feature flag sidebar_refactor.

To enable:

rails c
Feature.enable(:sidebar_refactor)

Screenshots (strongly suggested)

The right border on the panel in the "This MR with the flag" column below is not there anymore.

Project

master This MR without the flag This MR with the flag
Screenshot_2021-05-27_at_15.11.01 Screenshot_2021-05-27_at_14.09.51 Screenshot_2021-05-27_at_14.10.59

Group

The navigation for the groups have been refactored in the course of the whole effort hence the highlighted item differs from that in master (and this MR with the flag OFF)

master This MR without the flag This MR with the flag
Screenshot_2021-05-27_at_15.10.45 Screenshot_2021-05-27_at_14.08.37 Screenshot_2021-05-27_at_14.10.49

Admin Area

Admin Area panel has not been refactored in the backend yet so it doesn't have the required CSS class to avoid highlighting of the top-level menu item.

master This MR without the flag This MR with the flag
Screenshot_2021-05-27_at_15.10.29 Screenshot_2021-05-27_at_14.09.01 Screenshot_2021-05-27_at_14.10.34

User Preferences

master This MR without the flag This MR with the flag
Screenshot_2021-05-27_at_15.10.20 Screenshot_2021-05-27_at_14.09.11 Screenshot_2021-05-27_at_14.10.25

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #322680 (closed)

Edited by Andrei Stoicescu

Merge request reports

Loading