Skip to content

Fixed aria-hidden value

Tim Zallmann requested to merge tz-fix-aria-hidden-errors into master

What does this MR do?

Fixes aria-hidden values across the application as they are currently invalid with a boolean value as they then produce an aria-hidden instead of the correct aria-hidden="true". This simply converts all instances to a string value.

See - https://validator.w3.org/nu/?doc=https%3A%2F%2Fgitlab.com%2Fexplore

Fixed on https://gitlab-review-tz-fix-ari-urk79u.gitlab-review.app/explore

Bildschirmfoto_2021-05-27_um_17.22.48

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tim Zallmann

Merge request reports

Loading