Skip to content

Do not remove export when uploading via URL

What does this MR do?

This MR fixes a bug (although initially this was intended behaviour, which is no longer desired) where project export status was set to none when exporting to a URL. This can be confusing to a user, since it is not clear when the export finished.

This was happening because the after export strategy removes all exports, which makes export_status method to return none https://gitlab.com/gitlab-org/gitlab/blob/master/app/models/project.rb#L1948-1960

We want to accurately represent export status to show it as finished, instead of none and keep the export file around for potential future uses, e.g. if it needs to be redownloaded again.

Mentions #326269 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by George Koltsov

Merge request reports

Loading