Skip to content

Fixing empty HTML id values on MR page

Tim Zallmann requested to merge tz-fix-empty-ids into master

What does this MR do?

We are producing right now invalid HTML by having duplicate or empty ID's on HTML nodes. See https://validator.w3.org/nu/?doc=https%3A%2F%2Fgitlab.com%2Fgitlab-org%2Fgitlab-foss%2F-%2Fmerge_requests%2F12419

This MR fixes that problem for the MR page tabs + Filter dropdownds by creating ID's based on other values if none are provided.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tim Zallmann

Merge request reports

Loading