Skip to content

Authorize users to read `Vulnerabilities::IssueLink` records

What does this MR do?

It is possible that a vulnerability can be related to an issue that is not accessible by the current user even though the user can access the vulnerability. In that case, we shouldn't try to serialize that issue_link otherwise the issue property of the Types::Vulnerability::IssueLinkType will be null and cause an error since the property is marked as non-nullable.

This change basically fixes the error below;

"errors": [
  {
    "message": "Cannot return null for non-nullable field VulnerabilityIssueLink.issue"
  }
]

Related to #320990 (closed), and #331308 (closed).

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mehmet Emin INAC

Merge request reports

Loading