Skip to content

Add feature flag option to worker idempotency

Furkan Ayhan requested to merge idempotent-worker-with-ff into master

What does this MR do?

When trying to make PipelineProcessWorker idempotent (!62410 (merged)), I thought that it might be better if we could control this with a feature flag. I made the same changes over there but it is better to have it in a separate MR.

This MR adds the support of feature flag usage to the idempotent! method of workers.

Example

class PipelineProcessWorker
  include ApplicationWorker

  deduplicate :until_executing
  idempotent! feature_flag: :ci_idempotent_pipeline_process_worker

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Furkan Ayhan

Merge request reports

Loading