Skip to content

Fix deprecated GlIcon size and property

What does this MR do?

This MR removes the use-deprecated-sizes property in gl-icon component and update its size prop to use a valid size 16 in app/assets/javascripts/ide/components/merge_requests/item.vue

Closes #324780 (closed)

Part of https://gitlab.com/gitlab-com/marketing/community-relations/contributor-program/hackathon/-/issues/52

Screenshots (strongly suggested)

Before After
screenshot-3000-ivory-mongoose-uqh5jjpm.ws-eu09.gitpod.io-2021.06.16-13_28_31 screenshot-3000-ivory-mongoose-uqh5jjpm.ws-eu09.gitpod.io-2021.06.18-19_57_07

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Marvin Karegyeya

Merge request reports

Loading