Skip to content

Add compliance tab to redesigned Security-Configuration Page

Jannik Lehmann requested to merge secure-config-page-compliance-tab into master

What does this MR do?

This MR is meant to solve #328395 (closed)

It adds the Compliance Tab for the redesigned Security-Configuration Page.

The feature is currently hidden behind a feature Flag (security_configuration_redesign). The feature Flag is tracked here.

This MR includes:

  • Compliance Tab

The EE version of the Security Configuration Page has not been touched yet because it eventually will become obsolete.

The new Security Configuration Page will be data-driven from the Backend, to resolve the currently duplicated state of the pages and proceed with one single-source of truth in CE.

The EE version of the Security Configuration Page might include EE specific enhancements in the future.

How to reproduce

  1. make sure your GDK is running in FOSS mode (gitlab-development-kit/env.runit)
  2. enable security_configuration_redesign Feature Flag
  3. Go to any project -> Security & Compliance -> Configuration

Screenshots (strongly suggested)

before after
Screenshot_2021-06-02_at_16.03.18 Screenshot_2021-06-02_at_16.02.50

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jannik Lehmann

Merge request reports

Loading