Visualization lines aren't redrawn when editing the CI config
What does this MR do?
When the Ci config value changed, the lines that reprensents needs were disappearing. This commit fixes this problem but unmounting the graph when switching tab in the Pipeline Editor component. We use to not unmount it to optimize for performance, but this bug is not the first to arise from this early optimization. Given that when the pipeline data change, the DOM is completely changed anyway, we are not really gaining anything performance wise + introducing bug.
Note: There isn't really a unit test that could cover this fix, but perhaps an E2E could have covered this for the future.However, the PA group has currently no QA SET but we are getting one soon, so we are going to start building the coverage for our section.
Screenshots (strongly suggested)
| Before | After |
|---|---|
| Screen_Recording_2021-06-02_at_3.16.56_PM | Screen_Recording_2021-06-02_at_3.13.33_PM |
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #331546 (closed)