RSpec access matcher: Remove patched user after matcher is run
requested to merge 332442-flaky-test-ee-spec-requests-api-vulnerabilities_spec-rb-166-api-vulnerabilities-post into master
What does this MR do?
The first error is
expected this action to be allowed for admin role. Expected status code: any of 200, 201, 204, 302, 304 Got: 500
but then the second error is due torspec-retry
which doesn't unset:@__#{USER_ACCESSOR_METHOD_NAME}_patched
instance variable: https://gitlab.com/gitlab-org/gitlab/-/blob/6e7e449dba65077aca8faabc63848ebdcf662444/spec/support/helpers/access_matchers_helpers.rb#L64-66
This MR cleans up the user
patch after the matcher is run, so that we don't have issues when the matcher runs multiple times in an example group.
Related to #332442 (closed)
Does this MR meet the acceptance criteria?
Conformity
- [-] I have included a changelog entry, or it's not needed. (Does this MR need a changelog?)
- [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
- [-] I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
- [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Alishan Ladhani