Milestone sidebar widget
What does this MR do?
Uses generic dropdown sidebar widget (introduced for epics here: !62168 (merged)) for milestones.
The diff looks quite large because we're moving sidebar_dropdown_widget.vue
from EE (previously supporting epics and iterations) to CE (because we now support milestones). Very few changes are made to this component to add support of milestones and make sure iterations and epics are mentioned only in EE. I pointed out those changes on the diff to ease the review process.
This MR only uses the component on Issue boards (behind :graphql_board_lists
feature flag) , future iterations will use this component on Issue and Merge Request pages.
Screenshots (strongly suggested)
No visual changes
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #300642 (closed)