Skip to content

Say when MR was approved by me

What does this MR do?

This MR removes a duplication in the Merge Request approval message and specifically tells you when you are one of the MR approvers. The goal is to make it easier to clearly differentiate whether an MR was approved by you or other people (or both).

If there is text stating that approval is required or approval rules have to be statisfied, it is bold. Otherwise, the Approved by text will be bold. The text will be Approved by you when you are the sole approver, Approved by when only other people have approved the MR, and Approved by you and others when you are an approver and other people have also approved the MR.

Related to #331894 (closed)

Screenshots (strongly suggested)

State Before Implementation
Requires more approvals image image
Approved by others image image
Approved by you and others image image
Approved by you image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kev

Merge request reports

Loading