Say when MR was approved by me
What does this MR do?
This MR removes a duplication in the Merge Request approval message and specifically tells you when you are one of the MR approvers. The goal is to make it easier to clearly differentiate whether an MR was approved by you or other people (or both).
If there is text stating that approval is required or approval rules have to be statisfied, it is bold. Otherwise, the Approved by text will be bold. The text will be Approved by you when you are the sole approver, Approved by when only other people have approved the MR, and Approved by you and others when you are an approver and other people have also approved the MR.
Related to #331894 (closed)
Screenshots (strongly suggested)
| State | Before | Implementation |
|---|---|---|
| Requires more approvals |  |
 |
| Approved by others |  |
 |
| Approved by you and others |  |
 |
| Approved by you |  |
 |
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team