Add job-level keyword for DAST configuration
What does this MR do?
adds a new job-level keyword (dast_configuration
) that evolved from a discussion in an initial proposal.
Example
when you specify a site
or scanner
profile in the yaml
config, we will look up those records in the database by name and add the calculated variables to the build
using DastSiteProfile#ci_variables
and DastScannerProfile#ci_variables
.
dast:
stage: dast
dast_configuration:
site_profile: "site-profile-name"
scanner_profile: "scanner-profile-name"
script:
- echo
the merge request that adds new data model support here and the merge request that seeds the build is here.
Context
with dast
we have the concept of on-demand scans, which essentially entails storing dast
config in the database (dast_scanner_profiles
and dast_site_profiles
) and triggering scans via GraphQL on a manual basis. the proposal here is to reference those database entities by name in the .gitlab-ci.yml
and seed their configuration into pipelines triggered via the regular ci/cd process.
Why?
we want to give customers the ability to use dast
profiles in yaml
in order to simplify the configuration of DAST for customers.
Related Issue(s)
Related Merge Requests
- Add job-level keyword for DAST configuration
- Associate Build with DAST Site and Scanner profile
- Deliver DAST on-demand CI variables to builds
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team