Skip to content

Add project setting to toggle job token scope

Fabio Pitino requested to merge add-ci-project-setting-for-token-scope into master

What does this MR do?

Related to #329550 (closed)

This MR is a follow-up from !62733 (merged) where we introduced a scope of action for a CI_JOB_TOKEN to limit the projects it can access to.

In this MR we are adding a project setting to enable/disable this feature.

We introduce this setting as "disabled" in the database so it won't apply to existing projects but we set a default value true in the model so that new projects will have it enabled by default.

The change is applied behind a feature flag ci_scoped_job_token which was introduced in the previous MR.

Database migration

$ rails db:migrate:redo          
== 20210607154719 AddJobTokenScopeEnabledToCiCdSettings: reverting ============
-- remove_column(:project_ci_cd_settings, :job_token_scope_enabled)
   -> 0.0033s
== 20210607154719 AddJobTokenScopeEnabledToCiCdSettings: reverted (0.0132s) ===

== 20210607154719 AddJobTokenScopeEnabledToCiCdSettings: migrating ============
-- add_column(:project_ci_cd_settings, :job_token_scope_enabled, :boolean, {:default=>false, :null=>false})
   -> 0.0038s
== 20210607154719 AddJobTokenScopeEnabledToCiCdSettings: migrated (0.0098s) ===

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Pitino

Merge request reports

Loading